[libvirt] [PATCH V5 09/12] src/xenxs: Refactor code formating OS config

Jim Fehlig jfehlig at suse.com
Thu Aug 14 06:15:32 UTC 2014


Kiarie Kahurani wrote:
> introduce function
>    xenFormatXMOS(virConfPtr conf,........);
>   

I split this into three functions:

- xenFormatXMEmulator
- xenFormatXMCDROM
- xenFormatXMOS

Formating of emulator and cdrom can be different between xm and xl, and
we may want to account for that in the near future.

> which formats OS config instead
>
> Signed-off-by: Kiarie Kahurani <davidkiarie4 at gmail.com>
> ---
>  src/xenxs/xen_xm.c                                 | 95 ++++++++++++----------
>  tests/xmconfigdata/test-escape-paths.cfg           |  2 +-
>  tests/xmconfigdata/test-fullvirt-force-hpet.cfg    |  2 +-
>  tests/xmconfigdata/test-fullvirt-force-nohpet.cfg  |  2 +-
>  tests/xmconfigdata/test-fullvirt-localtime.cfg     |  2 +-
>  tests/xmconfigdata/test-fullvirt-net-ioemu.cfg     |  2 +-
>  tests/xmconfigdata/test-fullvirt-net-netfront.cfg  |  2 +-
>  tests/xmconfigdata/test-fullvirt-new-cdrom.cfg     |  2 +-
>  tests/xmconfigdata/test-fullvirt-old-cdrom.cfg     |  2 +-
>  tests/xmconfigdata/test-fullvirt-parallel-tcp.cfg  |  2 +-
>  .../test-fullvirt-serial-dev-2-ports.cfg           |  2 +-
>  .../test-fullvirt-serial-dev-2nd-port.cfg          |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-file.cfg   |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-null.cfg   |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-pipe.cfg   |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-pty.cfg    |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-stdio.cfg  |  2 +-
>  .../test-fullvirt-serial-tcp-telnet.cfg            |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-tcp.cfg    |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-udp.cfg    |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-unix.cfg   |  2 +-
>  tests/xmconfigdata/test-fullvirt-sound.cfg         |  2 +-
>  tests/xmconfigdata/test-fullvirt-usbmouse.cfg      |  2 +-
>  tests/xmconfigdata/test-fullvirt-usbtablet.cfg     |  2 +-
>  tests/xmconfigdata/test-fullvirt-utc.cfg           |  2 +-
>  tests/xmconfigdata/test-no-source-cdrom.cfg        |  2 +-
>  tests/xmconfigdata/test-pci-devs.cfg               |  2 +-
>   

Avoids changing all the test data files too. Simplified patch below.

BTW, I got interrupted during my earlier review, so "will push shortly"
had changed to "will push tomorrow" :-).

Regards,
Jim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: os-config.patch
Type: text/x-diff
Size: 7279 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140814/49484d1d/attachment-0001.bin>


More information about the libvir-list mailing list