[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: force configure failed when perl is missing



On Thu, Aug 14, 2014 at 11:37:45AM +0800, Jincheng Miao wrote:
> Perl is necessary to our build processing, it will invoke a lot of
> generating script, like: gendispatch.pl. If perl is missing, it's
> ok for build from git checkout, because autogen.sh will tell you.
> But for compiling from a release tarball, configure will just record
> a missing message, and continue, then build failed, like:
> https://www.redhat.com/archives/libvirt-users/2014-August/msg00050.html
> 
> So need to enhance configure script to handle this negative case.
> 
> Reported-by: Hongbin Lu <hongbin savinetwork ca>
> Signed-off-by: Jincheng Miao <jmiao redhat com>
> ---
>  configure.ac |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 081f298..af3fe28 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2173,6 +2173,9 @@ AM_CONDITIONAL([WITH_HYPERV], [test "$with_hyperv" = "yes"])
>  dnl Allow perl/python overrides
>  AC_PATH_PROGS([PYTHON], [python2 python])
>  AC_PATH_PROG([PERL], [perl])
> +if test -z "$PERL"; then
> +         AC_MSG_ERROR([Failed to find perl.])
> +fi
>  
>  AC_ARG_WITH([test-suite],
>              [AS_HELP_STRING([--with-test-suite],

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]