[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH V5 04/12] src/xenxs: Refactor code formating virtual time config



On Wed, Aug 13, 2014 at 05:15:58PM -0600, Jim Fehlig wrote:
> Kiarie Kahurani wrote:
> > introduce function
> >   xenFormatXMTimeOffset(virConfPtr conf,........);
> > which formats time config instead
> >
> > Signed-off-by: Kiarie Kahurani <davidkiarie4 gmail com>
> > ---
> >  src/xenxs/xen_xm.c | 153 ++++++++++++++++++++++++++++-------------------------
> >  1 file changed, 82 insertions(+), 71 deletions(-)
> >
> > diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c
> > index ad70b5a..b17574d 100644
> > --- a/src/xenxs/xen_xm.c
> > +++ b/src/xenxs/xen_xm.c
> > @@ -1704,6 +1704,86 @@ xenFormatXMMem(virConfPtr conf, virDomainDefPtr def)
> >  }
> >  
> >  
> > +static int
> > +xenFormatXMTimeOffset(virConfPtr conf, virDomainDefPtr def,
> > +                      int xendConfigVersion)
> >   
> 
> If function name + params exceeds 80 columns, common practice is each
> param after the first on a separate line. E.g.
> 
> xenFormatTimeOffset(virConfPtr conf,
> virDomainDefPtr def,
> int xendConfigVersion)
> {
> ...
> 
> > +{
> > +    int vmlocaltime;
> > +    if (xendConfigVersion < XEND_CONFIG_VERSION_3_1_0) {
> >   
> 
> Preferred style is a blank line after local variable declaration.
> 
> ACK otherwise. I'll fixup these nits before pushing.
> 
> Regards,
> Jim

BTW in the tests data I see configs like 
  <clock offset = 'utc' adjustment = 'reset'>
while if am not wrong the code in xen_xm.c explicity rejects such
config 

   unsupported clock adjustment = 'reset' 

> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]