[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/3] conf: Extend <loader/> and introduce <nvram/>

On 15.08.2014 16:13, Laszlo Ersek wrote:
On 08/15/14 15:43, Michal Privoznik wrote:
Up to now, users can configure BIOS via the <loader/> element. With
the upcoming implementation of UEFI this is not enough as BIOS and
UEFI are conceptually different. For instance, while BIOS is ROM, UEFI
is programmable flash (although all writes to code section are
denied). Therefore we need new attribute @type which will
differentiate the two. Then, new attribute @readonly is introduced to
reflect the fact that some images are RO.

Moreover, the OVMF (which is going to be used mostly), works in two
1) Code and UEFI variable store is mixed in one file.
2) Code and UEFI variable store is separated in two files

The latter has advantage of updating the UEFI code without losing the
configuration. However, in order to represent the latter case we need
yet another XML element: <nvram/>. Currently, it has no additional
attributes, it's just a bare element containing path to the variable
store file.

I compared this version against v1 1/3, and my earlier notes on that v1
patch. It looks good to me.

I don't know enough about libvirt to give an R-b that's really worth its
face value, so I'll just ack.

Acked-by: Laszlo Ersek <lersek redhat com>

In addition, is there an easy way for me to test this patchset? I can
pluck the series from the list, apply it manually to my upstream clone,
build etc. My main question is if there's going to be some interference
with my "normal", RHEL-7, system-wide libvirtd installation.

No, there shouldn't be any interference unless you 'make install'.

If I follow <http://libvirt.org/deployment.html> and just install (as
non-root) to a private --prefix, will that just work? I vaguely remember
that I did get this working once before (when I was working on commits
ccca5dc3 and 51e184e9), but I don't remember any longer.

You don't need even need to use that. I have libvirt installed via the packaging system on my distribution too and all I do is:

  ./autogen.sh --system && make

then I run (as root) ./run daemon/libvirtd and that's it.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]