[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] man: virsh: Add man page for "virsh metadata"



On 08/15/2014 09:12 AM, Peter Krempa wrote:
> Patch adding the command forgot to add the man page entry.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1130379
> ---
>  tools/virsh.pod | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index f07deec..d072a7f 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1254,6 +1254,36 @@ I<--total> for only the total stats, I<start> for only the per-cpu
>  stats of the CPUs from I<start>, I<count> for only I<count> CPUs'
>  stats.
> 
> +=item B<metadata> I<domain> [[I<--live>] [I<--config>] | [I<--current>]]
> +[I<--edit>] [I<uri>] [I<key>] [I<set>] [I<--remove>]

Looks good, but one suggestion (possibly as a followup patch):

I think =item B<desc> and =item B<metadata> should have cross-references
to one another, since we now have two separate virsh commands that both
map to the same underlying libvirt API.

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]