[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] [PATCH 1/4] GVirDomain: Fix some doc comments of the snapshot API



Hey,

On Fri, Aug 15, 2014 at 12:05:44PM +0200, Timm Bäder wrote:
> Fixes some warnings from g-ir-scanner.
> ---
>  libvirt-gobject/libvirt-gobject-domain.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c
> index feac6f0..aa2a170 100644
> --- a/libvirt-gobject/libvirt-gobject-domain.c
> +++ b/libvirt-gobject/libvirt-gobject-domain.c
> @@ -1529,10 +1529,10 @@ gvir_domain_create_snapshot(GVirDomain *dom,
>   * gvir_domain_fetch_snapshots:
>   * @dom: The domain
>   * @list_flags: bitwise-OR of #GVirDomainSnapshotListFlags
> - * @cancellable: (allow-none)(transfer-none): cancellation object
> - * @error: (allow-none): Place-holder for error or NULL
> + * @cancellable: (allow-none) (transfer none): cancellation object
> + * @error: (allow-none): Place-holder for error or %NULL
>   *
> - * Returns: TRUE on success, FALSE otherwise.
> + * Returns: %TRUE on success, %FALSE otherwise.
>   */
>  gboolean gvir_domain_fetch_snapshots(GVirDomain *dom,
>                                       guint list_flags,
> @@ -1647,10 +1647,10 @@ static void _fetch_snapshots_async_thread(GTask *task,
>  
>  
>  /**
> - *
> + * gvir_domain_fetch_snapshots_async:
>   * @dom: The domain
>   * @list_flags: bitwise-OR of #GVirDomainSnapshotListFlags
> - * @cancellable: (allow-none)(transfer-none): cancellation object
> + * @cancellable: (allow-none) (transfer none): cancellation object

Is g-ir-scanner complaining about the lack of space? or just about
'transfer-none'? Just being curious, patch looks good to me, ACK. For
future commits, c&p-ing the g-ir-scanner warnings that you are fixing in
the commit log can be useful)

Christophe

Attachment: pgpqYm85MBwb3.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]