[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] [PATCH 1/4] GVirDomain: Fix some doc comments of the snapshot API



On 18.08, Christophe Fergeau wrote:
> Hey,
> 
> On Fri, Aug 15, 2014 at 12:05:44PM +0200, Timm Bäder wrote:
> >  /**
> > - *
> > + * gvir_domain_fetch_snapshots_async:
> >   * @dom: The domain
> >   * @list_flags: bitwise-OR of #GVirDomainSnapshotListFlags
> > - * @cancellable: (allow-none)(transfer-none): cancellation object
> > + * @cancellable: (allow-none) (transfer none): cancellation object
> 
> Is g-ir-scanner complaining about the lack of space? or just about
> 'transfer-none'? Just being curious, patch looks good to me, ACK. For
> future commits, c&p-ing the g-ir-scanner warnings that you are fixing in
> the commit log can be useful)
I'll have to check but IIRC it was mostly about the missing function
name on the first line and once I fixed that, it was the transfer-none,
yes. The whitespace fixes are just cosmetic.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]