[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PREPOST] XL parser

Kiarie Kahurani (1):
  src/xenconfig: XL parser

 po/POTFILES.in                                |   1 +
 src/Makefile.am                               |   3 +-
 src/libvirt_xenconfig.syms                    |   5 +
 src/libxl/libxl_driver.c                      |  44 ++-
 src/xenconfig/xen_common.c                    | 140 ++++----
 src/xenconfig/xen_common.h                    |  24 +-
 src/xenconfig/xen_xl.c                        | 461 ++++++++++++++++++++++++++
 src/xenconfig/xen_xl.h                        |  29 ++
 tests/Makefile.am                             |   9 +-
 tests/testutilsxen.c                          |  50 +++
 tests/testutilsxen.h                          |   9 +-
 tests/xlconfigdata/test-fullvirt-new-disk.cfg |  27 ++
 tests/xlconfigdata/test-fullvirt-new-disk.xml |  46 +++
 tests/xlconfigtest.c                          | 222 +++++++++++++
 14 files changed, 981 insertions(+), 89 deletions(-)
 create mode 100644 src/xenconfig/xen_xl.c
 create mode 100644 src/xenconfig/xen_xl.h
 create mode 100644 tests/xlconfigdata/test-fullvirt-new-disk.cfg
 create mode 100644 tests/xlconfigdata/test-fullvirt-new-disk.xml
 create mode 100644 tests/xlconfigtest.c

After *toooo* long the xen-xl parser has arrived with support for 
xl disk format and spice graphics(with admittedly very kludgy code)

quick overview 

1)coverts xl disk config such as 

     disk = ["/dev/sda,raw,hda,rw,"]

    into xml config 

      <disk type='block' device='disk'>
        <driver name='phy'/>
        <source dev='/dev/sda/'>
        <target dev= 'hda' bus='ide'/>

    and vice-versa

    You notice that in the xl disk config there is no driver type but
    it appears on the xml; I use the format to intelligently guess the 
    driver but this does not look very good again you notice I do not
    support disk backend config which is because there is no member of
    _virDomainDiskDef which I could relate to the backend

2)converts spice graphics config 
    spice = 1
    spicehost = ""
    spiceport = 500
    spicetls_port = 590 
    spicedisable_ticketing = 1 #with this set you require a passwd
    spicepasswd = "thebeast"
    spiceagent_mouse = 1

    <graphics type='spice' port='500' tlsPort='590' autoport='no' listen=''>
      <listen type='address' address=''/>
        <mouse mode='server'/>

    and vice-versa

    You notice that the passwd is not in the xml, am still trying to figure out why

    Again you will notice the current tests are a bit dependent on xen code(when 
    initializing the xmlOpt) which would *better* be done away with but that would
    require some code in src/libxl/

    Into the bargain, am not *sure* how exactly to initialize _virCapsPtr which is 
    reqiured for xml formatting because I *assume* that tests should be able to run
    even with drivers not loaded.

    Am also not *sure* that how to map disks to device type, the existing code(xm) 
    code maps all the disks using another driver other than 'phy' to 'block'.Am not
    sure this is correct.

    With the current patch 

      $virsh domxml-from/to-native xen-xl works perfectly

    Fix tests

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]