[libvirt] [PATCH] libxl: do not use hardcoded pygrub path

[Jim Fehlig]

On 08/19/2014 10:33 AM, Álvaro López García wrote:
> Hi Daniel,
>
> On Tue 19 Aug 2014 (14:32), Daniel P. Berrange wrote:
>> On Tue, Aug 19, 2014 at 01:54:12PM +0200, Alvaro Lopez Garcia wrote:
>>> According to the Xen documentation the full path was only needed
>>> for versions prior to 4.1: "Note: For older versions of Xen Project
>>> software (4.1 or earlier) you need to know where in the filesystem
>>> pygrub lies. (...) Newer versions of the toolstack know how to look
>>> for the path themselves." [1]
>> Regardless of whether they know how to find the path, it is expected
>> that the libvirt XML is including/requiring the full path. So I'm
>> not really considering this a bug that needs fixing
> - Is it required that all the libvirt XML files needing a bootloader
>    specify one? or

No.  But if you don't specify one, you get /usr/bin/pygrub, which is similar to 
xend's behavior.

> - If the bootloader is specified, then it has to be a full path?

No.

>
> If it is the former case, we have been running libvirt with xend without
> specifying a bootloader in the XML files for a long time.

If not specified, xend sets bootloader to 'usr/bin/pygrub'.

>   We only have
> found issues when we switched our hypervisors from xend to libxl.

What issues?  AFAIK, only a warning in the log.

Regards,
Jim