[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] cleanup spaces between parentheses and curly brackets



On 08/20/2014 05:10 AM, Martin Kletzander wrote:
> And add a syntax-check for '){$'.  It's not perfect, but better than
> nothing.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---

> +++ b/cfg.mk
> @@ -943,6 +943,12 @@ sc_prohibit_empty_first_line:
>  	  print "$(ME): Prohibited empty first line" > "/dev/stderr";	\
>  	} exit fail; }' $$($(VC_LIST_EXCEPT));
> 
> +sc_prohibit_parentheses_conjuncted_with_curly_bracket:

Awkward name.  Maybe sc_prohibit_paren_curly: is sufficient. But that's
just bike-shedding.

> +	@prohibit='\)\{$$'						\
> +	in_vc_files='\.[ch]$$'						\

Probably also worth checking .x, as in '\.[chx]$$'

> +	halt='put space between parentheses and curly bracket'		\

I tend to think of '(' as parenthesis, '[' as bracket, and '{' as brace;
but I've also heard people refer to '(' as round bracket, '[' as square
bracket, and '{' as curly bracket.  So this message is okay, even if I
would have used "brace" instead of "curly bracket".

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]