[libvirt] [PATCH] cleanup spaces between parentheses and curly brackets

[Martin Kletzander]

On Wed, Aug 20, 2014 at 06:36:56AM -0600, Eric Blake wrote:
>On 08/20/2014 05:10 AM, Martin Kletzander wrote:
>> And add a syntax-check for '){$'.  It's not perfect, but better than
>> nothing.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>
>> +++ b/cfg.mk
>> @@ -943,6 +943,12 @@ sc_prohibit_empty_first_line:
>>  	  print "$(ME): Prohibited empty first line" > "/dev/stderr";	\
>>  	} exit fail; }' $$($(VC_LIST_EXCEPT));
>>
>> +sc_prohibit_parentheses_conjuncted_with_curly_bracket:
>
>Awkward name.  Maybe sc_prohibit_paren_curly: is sufficient. But that's
>just bike-shedding.
>

I went with paren_braces.

>> +	@prohibit='\)\{$$'						\
>> +	in_vc_files='\.[ch]$$'						\
>
>Probably also worth checking .x, as in '\.[chx]$$'
>

Good point, although I don't think it'll catch much there.

>> +	halt='put space between parentheses and curly bracket'		\
>
>I tend to think of '(' as parenthesis, '[' as bracket, and '{' as brace;
>but I've also heard people refer to '(' as round bracket, '[' as square
>bracket, and '{' as curly bracket.  So this message is okay, even if I
>would have used "brace" instead of "curly bracket".
>

And that's how we are using it in almost all places in libvirt, so I
adjusted it to match.

>ACK
>

Thanks for the review, will push in a while.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140820/5488d4d8/attachment-0001.sig>