[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] Parallels: Add video acceleration parameter change ignore.



On Wed, Aug 20, 2014 at 07:33:07PM +0400, Alexander Burluka wrote:
> As long as OpenStack's Nova does not know anything about
> video card acceleration, 2D and 3D acceleration parameters
> are unset in input XML generated by Nova. Any change of
> these parameters is ignored now.
> ---
>  src/parallels/parallels_driver.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
> index 3806e5e..c19aa96 100644
> --- a/src/parallels/parallels_driver.c
> +++ b/src/parallels/parallels_driver.c
> @@ -1621,10 +1621,8 @@ parallelsApplyVideoParams(parallelsDomObjPtr pdom,
>          old->accel->support2d != new->accel->support2d ||
>          old->accel->support3d != new->accel->support3d) {
>  
> -        virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
> -                   _("Changing video acceleration parameters is "
> -                     "not supported by parallels driver"));
> -        return -1;
> +        VIR_WARN("Changing video acceleration parameters is "
> +                     "not supported by parallels driver");
>      }

Afraid this isn't right. It is our policy that any time a bit of XML config
is request that the hypervisor is not able to support, we should raise an
error of VIR_ERR_CONFIG_UNSUPPORTED.

So if anything this patch should merely change the current error code
used. s/ARGUMENT/CONFIG/

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]