[libvirt] [PATCH] hvsupport: Adapt to vbox driver rewrite

Taowei Luo uaedante at gmail.com
Thu Aug 21 10:23:07 UTC 2014


Thinks for fixing this! I am suffering compiling error with hvsupport (yet
have no idea why) for several days.


2014-08-21 0:44 GMT+08:00 Michal Privoznik <mprivozn at redhat.com>:

> On 20.08.2014 18:31, Peter Krempa wrote:
>
>> On 08/20/14 18:20, Michal Privoznik wrote:
>>
>>> Since vbox driver rewrite the virDriver structure init moved from
>>> vbox_tmpl.c into vbox_common.c. However, our hvsupport.pl script
>>> doesn't count with that. It still parses vbox_tmp.c and looks for
>>> virDriver structure which is not found there anymore. As a result,
>>> at hvsupport page is seems like vbox driver doesn't support
>>> anything.
>>>
>>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>>> ---
>>>   docs/hvsupport.pl      | 2 +-
>>>   src/vbox/vbox_driver.c | 2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/docs/hvsupport.pl b/docs/hvsupport.pl
>>> index f8483f9..34ba599 100755
>>> --- a/docs/hvsupport.pl
>>> +++ b/docs/hvsupport.pl
>>> @@ -28,7 +28,7 @@ my %groupheaders = (
>>>   my @srcs;
>>>   find({
>>>       wanted => sub {
>>> -        if (m!$srcdir/.*/\w+_(driver|tmpl|monitor|hal|udev)\.c$!) {
>>> +        if (m!$srcdir/.*/\w+_(driver|common|tmpl|monitor|hal|udev)\.c$!)
>>> {
>>>
>>
>> tmpl will need to be purged once the vbox driver rewrite is done
>>
>
> Yeah, I'm keeping it until the time the storage and network drivers are
> rewritten too. I saw Taowei proposed patches, but haven't reviewed them yet.
>
>
>
>>                push @srcs, $_ if $_ !~ /vbox_driver\.c/;
>>>           }
>>>       }, no_chdir => 1}, $srcdir);
>>> diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c
>>> index f0c05fe..498be71 100644
>>> --- a/src/vbox/vbox_driver.c
>>> +++ b/src/vbox/vbox_driver.c
>>> @@ -210,5 +210,5 @@ static virDrvOpenStatus
>>> dummyConnectOpen(virConnectPtr conn,
>>>   static virDriver vboxDriverDummy = {
>>>       VIR_DRV_VBOX,
>>>       "VBOX",
>>> -    .connectOpen = dummyConnectOpen,
>>> +    .connectOpen = dummyConnectOpen, /* 0.6.3 */
>>>   };
>>>
>>>
>> ACK
>>
>> Peter
>>
>>
>
> Pushed now, thanks!
>
> Michal
>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140821/3ad0b397/attachment-0001.htm>


More information about the libvir-list mailing list