[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 1/3] conf: Extend <loader/> and introduce <nvram/>



On 08/21/14 10:50, Michal Privoznik wrote:
> Up to now, users can configure BIOS via the <loader/> element. With
> the upcoming implementation of UEFI this is not enough as BIOS and
> UEFI are conceptually different. For instance, while BIOS is ROM, UEFI
> is programmable flash (although all writes to code section are
> denied). Therefore we need new attribute @type which will
> differentiate the two. Then, new attribute @readonly is introduced to
> reflect the fact that some images are RO.
> 
> Moreover, the OVMF (which is going to be used mostly), works in two
> modes:
> 1) Code and UEFI variable store is mixed in one file.
> 2) Code and UEFI variable store is separated in two files
> 
> The latter has advantage of updating the UEFI code without losing the
> configuration. However, in order to represent the latter case we need
> yet another XML element: <nvram/>. Currently, it has no additional
> attributes, it's just a bare element containing path to the variable
> store file.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  docs/formatdomain.html.in                          | 19 ++++-
>  docs/schemas/domaincommon.rng                      | 21 ++++++
>  src/conf/domain_conf.c                             | 87 +++++++++++++++++++++-
>  src/conf/domain_conf.h                             | 22 +++++-
>  src/libvirt_private.syms                           |  3 +
>  src/qemu/qemu_command.c                            |  5 +-
>  src/security/virt-aa-helper.c                      |  4 +-
>  src/vbox/vbox_common.c                             |  7 +-
>  src/xenapi/xenapi_driver.c                         |  3 +-
>  src/xenconfig/xen_common.c                         |  7 +-
>  src/xenconfig/xen_sxpr.c                           | 16 ++--
>  tests/qemuxml2argvdata/qemuxml2argv-bios-nvram.xml | 40 ++++++++++
>  .../qemuxml2xmlout-pci-bridge-many-disks.xml       |  2 +-
>  tests/qemuxml2xmltest.c                            |  2 +
>  tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml      |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml  |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml    |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml  |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml        |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-legacy-vfb.xml    |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml     |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml     |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml  |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml  |  2 +-
>  .../sexpr2xml-fv-serial-dev-2-ports.xml            |  2 +-
>  .../sexpr2xml-fv-serial-dev-2nd-port.xml           |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml   |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml   |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml   |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml    |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml  |  2 +-
>  .../sexpr2xml-fv-serial-tcp-telnet.xml             |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml    |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml    |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml   |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml     |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-sound.xml         |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml      |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml     |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-utc.xml           |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-v2.xml            |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv.xml               |  2 +-
>  tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml  |  2 +-
>  tests/xmconfigdata/test-escape-paths.xml           |  2 +-
>  tests/xmconfigdata/test-fullvirt-force-hpet.xml    |  2 +-
>  tests/xmconfigdata/test-fullvirt-force-nohpet.xml  |  2 +-
>  tests/xmconfigdata/test-fullvirt-localtime.xml     |  2 +-
>  tests/xmconfigdata/test-fullvirt-net-ioemu.xml     |  2 +-
>  tests/xmconfigdata/test-fullvirt-net-netfront.xml  |  2 +-
>  tests/xmconfigdata/test-fullvirt-new-cdrom.xml     |  2 +-
>  tests/xmconfigdata/test-fullvirt-old-cdrom.xml     |  2 +-
>  tests/xmconfigdata/test-fullvirt-parallel-tcp.xml  |  2 +-
>  .../test-fullvirt-serial-dev-2-ports.xml           |  2 +-
>  .../test-fullvirt-serial-dev-2nd-port.xml          |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-file.xml   |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-null.xml   |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-pipe.xml   |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-pty.xml    |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-stdio.xml  |  2 +-
>  .../test-fullvirt-serial-tcp-telnet.xml            |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-tcp.xml    |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-udp.xml    |  2 +-
>  tests/xmconfigdata/test-fullvirt-serial-unix.xml   |  2 +-
>  tests/xmconfigdata/test-fullvirt-sound.xml         |  2 +-
>  tests/xmconfigdata/test-fullvirt-usbmouse.xml      |  2 +-
>  tests/xmconfigdata/test-fullvirt-usbtablet.xml     |  2 +-
>  tests/xmconfigdata/test-fullvirt-utc.xml           |  2 +-
>  tests/xmconfigdata/test-no-source-cdrom.xml        |  2 +-
>  tests/xmconfigdata/test-pci-devs.xml               |  2 +-
>  69 files changed, 269 insertions(+), 79 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-bios-nvram.xml

Acked-by: Laszlo Ersek <lersek redhat com>

(Please append this line to the commit message in any further reposts.)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]