[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: check for active domain after agent interaction



On 08/21/2014 12:50 AM, Martin Kletzander wrote:
> On Wed, Aug 20, 2014 at 03:35:08PM -0600, Eric Blake wrote:
>> Commit b606bbb41 reminded me that any time we drop locks to run
>> back-to-back guest interaction commands, we have to check that
>> the guest didn't disappear in between the two commands.  A quick
>> audit found a couple of spots that were missing this check.
>>
>> * src/qemu/qemu_driver.c (qemuDomainShutdownFlags)
>> (qemuDomainSetVcpusFlags): Check that domain is still up.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>

> 
> I'm thinking about a place where we could stick this to make it more
> generic, but can't find one.  That would be a completely different
> cleanup anyway, so ACK to this.

Thanks; pushed.

About the only idea I had would be making qemuDomainObjExitAgent()
return a value marked ATTRIBUTE_RETURN_CHECK, where the caller can be
informed if the guest is still running every time it regains control
after temporarily dropping locks; but that is, as you say, a completely
different cleanup because it would touch a lot of callers.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]