[libvirt] [PATCHv2] iotune: setting an invalid value now reports error

Ján Tomko jtomko at redhat.com
Mon Aug 25 14:48:36 UTC 2014


On 08/25/2014 10:50 AM, Erik Skultety wrote:
> When trying to set an invalid value into iotune element, standard
> behavior was to not report any error, rather to reset all affected
> subelements of the iotune element back to 0 which results in ignoring
> those particular subelements by XML generator. Patch further
> examines the return code of the virXPathULongLong function
> and in case of an invalid non-integer value raises an error.
> Fixed to preserve consistency with invalid value checking
> of other elements.
> 
> Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1131811
> ---
>  src/conf/domain_conf.c | 67 ++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 49 insertions(+), 18 deletions(-)

ACK and pushed.

Jan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140825/66e44545/attachment-0001.sig>


More information about the libvir-list mailing list