[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] docs, conf: add support for bootmenu timeout



On 08/25/2014 10:09 AM, Martin Kletzander wrote:

>>> +      Additional attribute <code>timeout</code> takes the number of
>>> milliseconds
>>> +      the boot menu should wait until it times out.  Allowed values
>>> are numbers
>>> +      in range [0, 65535] inclusive and it is valid if and only if
>>> the previous
>>> +      <code>enable</code> is set to "yes".
>>
>> You know, it is possible to have RelaxNG enforce this restriction:
>>
> 
> Yes, but I wanted it to be just ignored if enable="no".  There are, of
> course, other options, like keeping it there, but not using it or
> leaving what it does on qemu.  I gues I could add "otherwise it gets
> ignored" at the end of the sentence.  Should I do that, change the
> behaviour or add the checks (and adjust tests of course)?  It needs a
> follow-up, though since I already pushed it thanks to Jan's ACK.

Maybe the simplest thing is a followup which changes:

s/it is valid if and only if the previous enable is set to yes/it is
ignored unless enable is set to yes/


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]