[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] Add new 'kvm' domain feature and ability to hide KVM signature



On 08/25/2014 05:13 PM, Ján Tomko wrote:
> On 08/21/2014 07:04 PM, Alex Williamson wrote:
>> QEMU 2.1 added support for the kvm=off option to the -cpu command,
>> allowing the KVM hypervisor signature to be hidden from the guest.
>> This enables disabling of some paravirualization features in the
>> guest as well as allowing certain drivers which test for the
>> hypervisor to load.  Domain XML syntax is as follows:
>>
>> <domain type='kvm>
>>   ...
>>   <features>
>>     ...
>>     <kvm>
>>       <hidden state='on'/>
>>     </kvm>
>>   </features>
>>   ...
>>
>> Signed-off-by: Alex Williamson <alex williamson redhat com>
>> ---
>>
>> Hearing no further comments, here's v2:
>>  - white space fix in docs/formatdomain.html.in
>>  - s/virBufferAsprintf/virBufferAddLit/ in src/qemu/qemu_command.c
>>
>>  docs/formatdomain.html.in                          |   21 ++++
>>  docs/schemas/domaincommon.rng                      |   18 +++-
>>  src/conf/domain_conf.c                             |  100 ++++++++++++++++++++
>>  src/conf/domain_conf.h                             |    9 ++
>>  src/qemu/qemu_command.c                            |   22 ++++
>>  tests/qemuargv2xmltest.c                           |    2 
>>  .../qemuxml2argv-kvm-features-off.args             |    5 +
>>  .../qemuxml2argv-kvm-features-off.xml              |   27 +++++
>>  .../qemuxml2argv-kvm-features.args                 |    5 +
>>  .../qemuxml2argvdata/qemuxml2argv-kvm-features.xml |   27 +++++
>>  tests/qemuxml2argvtest.c                           |    3 +
>>  tests/qemuxml2xmltest.c                            |    3 +
>>  12 files changed, 240 insertions(+), 2 deletions(-)
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-kvm-features-off.args
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-kvm-features-off.xml
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-kvm-features.args
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-kvm-features.xml
> 
> ACK
> 
> I will push this tomorrow unless someone has a different opinion.
> 

Pushed now.

> (This didn't compile for me at the first try. Turns out 'git am' misplaced the
> virDomainDefFeaturesCheckABIStability hunk.)
> 
> Jan
> 
> 
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]