[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] domain_conf: Introduce iothreads XML



On 08/25/2014 06:38 PM, John Ferlan wrote:
> Introduce XML to allowing adding iothreads to the domain. These can be
> used by virtio-blk-pci devices in order to assign a specific thread to
> handle the workload for the device.  The iothreads are the official
> implementation of the virtio-blk Data Plane that's been in tech preview
> for QEMU.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---

> @@ -4747,6 +4753,12 @@
>        <param name="minInclusive">1</param>
>      </data>
>    </define>
> +  <define name="countIOThreads">
> +    <data type="unsignedInt">
> +      <param name="pattern">[0-9]+</param>
> +      <param name="minInclusive">0</param>
> +    </data>

Isn't minInclusive 0 of an unsignedInt redundant? It only matters for an
integer that must be larger than zero, so you could omit a line.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]