[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/4] domain_conf: Add support for iothreads in disk definition




On 08/27/2014 02:42 AM, Martin Kletzander wrote:
> On Tue, Aug 26, 2014 at 06:15:48PM -0400, John Ferlan wrote:
>> Add a new disk "driver" attribute "iothread" to be parsed as the thread
>> number for the disk to use. In order to more easily facilitate the usage
>> and configuration of the iothread, a "zero" for the attribute indicates
>> iothreads are not supported for the device and a positive value indicates
>> the specific thread to try and use.
>>
>> Signed-off-by: John Ferlan <jferlan redhat com>
>> ---
>> docs/formatdomain.html.in     |  8 ++++++++
>> docs/schemas/domaincommon.rng |  8 ++++++++
>> src/conf/domain_conf.c        | 27 ++++++++++++++++++++++++++-
>> src/conf/domain_conf.h        |  2 ++
>> 4 files changed, 44 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>> index b584a08..132952d 100644
>> --- a/docs/formatdomain.html.in
>> +++ b/docs/formatdomain.html.in
>> @@ -2160,6 +2160,14 @@
>>             (ignore the discard request).
>>             <span class='since'>Since 1.0.6 (QEMU and KVM only)</span>
>>           </li>
>> +          <li>
>> +            The optional <code>iothread</code> attribute will assign the
> 
> I'm rather fan of "assigns" then "will assign", but both make sense here.
> 
> ACK either way.
> 
> Martin
> 

"assigns" it is then :-) (use of 'will' is probably that passive side of
things)

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]