[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 4/6] qemu: Build command line for ivshmem device



On Tue, Aug 26, 2014 at 10:58 AM, Martin Kletzander <mkletzan redhat com> wrote:
> On Fri, Aug 22, 2014 at 12:47:03PM +0200, Maxime Leroy wrote:
>>
[..]
>
> It will sometimes format the command-line parameter to size=0m, which
> will terribly fail.  We should add it to the command-line with the
> smallest scale possible, so it can be configured to the tiniest bit
> (and it will also get rid of this error).
>

As explain in my previous email, Ivshmem in qemu only accepts size in MB or GB.

To prevent this error, we should not accept size under 1MB, in
virDomainIvshmemDefParseXML:

 if (virDomainParseScaledValue("./size[1]", ctxt,
 -                             &def->size, 1,
 +                            &def->size, 1024x1024,
                               ULLONG_MAX, true) < 0)

Maxime


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]