[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 5/6] tests: Add tests for ivshmem device handling



On Wed, Aug 27, 2014 at 11:02:36PM +0200, Maxime Leroy wrote:
On Tue, Aug 26, 2014 at 11:02 AM, Martin Kletzander <mkletzan redhat com> wrote:
On Fri, Aug 22, 2014 at 12:47:04PM +0200, Maxime Leroy wrote:

[...]
+    <shmem name='shmem0' model='ivshmem'>
+      <server path='/tmp/socket-shmem0'/>
+      <msi vectors='32' ioeventfd='on'/>
+    </shmem>
+    <shmem name='shmem1' model='ivshmem'>
+      <server path='/tmp/socket-shmem1'/>
+      <size unit='M'>32</size>
+      <msi vectors='32'/>


The qemuxml2xmltest didn't faile with this xml, which means we are not
allocating addresses for shmem devices.  We have to do that and put it
in the XML so (a) the address won't change and (b) that we know which
address is occupied by that in case we'll want to attach something to
the VM.


Ok. Thanks.

And xml2xml (and PARSE_ERROR xml2argv) tests can be squashed into the patch
with documentation and parsing.  Other xml2argv tests can be squashed
into the patch where qemu formats the command-line.


Ok.

I also should merge the documentation and parsing commit ?


That's a common practice, it ensures that if anyone back-ports any
commits anywhere, the documentation will match the parsing and tests
will be included as well.  It's not super-strict, but it's nice to
have and it also helps review sometimes.

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]