[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu_driver: Resolve Coverity FORWARD_NULL



On 08/28/2014 01:28 PM, John Ferlan wrote:
> In qemuDomainSnapshotCreateDiskActive() if we jumped to cleanup from a
> failed actions = virJSONValueNewArray(), then 'cfg' would be NULL.
> 
> So just return -1, which in turn removes the need for cleanup:
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/qemu/qemu_driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]