[libvirt] [PATCH 2/2] qemu_driver: Resolve Coverity FORWARD_NULL

Eric Blake eblake at redhat.com
Thu Aug 28 21:07:32 UTC 2014


On 08/28/2014 01:28 PM, John Ferlan wrote:
> In qemuDomainSnapshotCreateDiskActive() if we jumped to cleanup from a
> failed actions = virJSONValueNewArray(), then 'cfg' would be NULL.
> 
> So just return -1, which in turn removes the need for cleanup:
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140828/c92018ce/attachment-0001.sig>


More information about the libvir-list mailing list