[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [python PATCH 2/5] API: Skip 'virDomainStatsRecordListFree'



On 08/28/2014 06:32 PM, Peter Krempa wrote:
> The new API function doesn't make sense to be exported in python. The
> bindings will return native types instead of the struct array.
> ---
>  generator.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/generator.py b/generator.py
> index 9c497be..cfc016e 100755
> --- a/generator.py
> +++ b/generator.py
> @@ -571,6 +571,7 @@ skip_function = (
>      "virTypedParamsGetULLong",
> 
>      'virNetworkDHCPLeaseFree', # only useful in C, python code uses list
> +    'virDomainStatsRecordListFree', # only useful in C, python uses dict
>  )
> 
>  lxc_skip_function = (
> 


You also have to add this hunk to make the sanitytest happy:

diff --git a/sanitytest.py b/sanitytest.py
index 4f4a648..10cf9f0 100644
--- a/sanitytest.py
+++ b/sanitytest.py
@@ -81,6 +81,9 @@ for cname in wantfunctions:
     if name[0:23] == "virNetworkDHCPLeaseFree":
         continue

+    if name[0:28] == "virDomainStatsRecordListFree":
+        continue
+
     # These aren't functions, they're callback signatures
     if name in ["virConnectAuthCallbackPtr", "virConnectCloseFunc",
                 "virStreamSinkFunc", "virStreamSourceFunc",
"virStreamEventCallback",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]