On Fri, Aug 29, 2014 at 10:37:21AM +0200, Christophe Fergeau wrote:
Since 1b807f92, connecting with virsh to an already running session libvirtd fails with: $ virsh list --all error: failed to connect to the hypervisor error: no valid connection error: Failed to connect socket to '/run/user/1000/libvirt/libvirt-sock': Transport endpoint is already connected This is caused by a logic error in virNetSocketNewConnectUnix: even if the connection to the daemon socket succeeded, we still try to spawn the daemon and then connect to it. This commit changes the logic to not try to spawn libvirtd if we successfully connected to its socket.
Thanks for trying that, that was a flaw in my condition-optimization mechanism, I guess. Although my git was a bit confused by the diff included in the commit message. I'd suggest just saying that most of the commit is a whitespace change; people can see that using '-w' themselves. That toggle should even work with format-patch, but I'm not sure that applies cleanly all the time. ACK with the commit cleaned up and safe for 1.2.8. Thank you, Martin
Description: Digital signature