[libvirt] [PATCH v2 0/2] virsh: Don't wait for reconnection when it's unnecessary

Martin Kletzander mkletzan at redhat.com
Mon Dec 1 11:00:51 UTC 2014


Before when disconnected due to keepalive timeout:

 $ virsh -k1 -K1 list
 2014-12-01 10:58:42.725+0000: 1643: info : libvirt version: 1.2.11
 2014-12-01 10:58:42.725+0000: 1643: warning : virKeepAliveTimerInternal:143 : No response from client 0x7fa8b7c46f70 after 1 keepalive messages in 2 seconds
 2014-12-01 10:58:42.725+0000: 1644: warning : virKeepAliveTimerInternal:143 : No response from client 0x7fa8b7c46f70 after 1 keepalive messages in 2 seconds
 error: Failed to list domains

* virsh hangs here until reconnected or killed, if reconnected:

error: internal error: received hangup / error event on socket

After (the same scenario):

 $ virsh -k1 -K1 list
 error: Failed to list domains
 error: internal error: No response from client 0x7ff0e9545f70 after 1 keepalive messages in 2 seconds

* virsh doesn't hang :)

Martin Kletzander (2):
  rpc: Report proper close reason for keepalive disconnections
  virsh: Don't reconnect after the command when disconnected

 src/rpc/virkeepalive.c | 11 ++++++-----
 src/rpc/virnetclient.c |  1 +
 tools/virsh.c          |  3 ---
 3 files changed, 7 insertions(+), 8 deletions(-)

--
2.1.3




More information about the libvir-list mailing list