[libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

[Giuseppe Scrivano]

Pavel Hrdina <phrdina at redhat.com> writes:

> The vgamem is a new attribute for QXL. The vram stil exists and its
> only silently updated to proper value. The configuration with vram=9216
> is wrong and should be updated in virt-manager tests.

the issue exists when the type of an existing QXL device is changed.
virt-manager re-uses the XML configuration without modifying attributes
it doesn't understand (as vgamem in this case) but changing only
type='qxl' to type='$NEW_TYPE'.

My doubt here is if an additional attribute should be silently ignored
or users of the API should be filtering it out if type != 'qxl'.
Another point is that this attribute will be added in future for some
other models, then all users must be updated as well to support it,
instead of having it only in libvirt.

What do you think?

Regards,
Giuseppe