[libvirt] [PATCH] libvirt.spec.in: BuildRequires: python-devel

[Eric Blake]

On 12/01/2014 09:21 AM, Michal Privoznik wrote:
> As of f48ab7d8 we are trying to use python-devel to check python's
> version (or at least gnulib is doing that). However, the specfile
> doesn't say anything about it and therefore bootstrapping may fail
> on a minimal installation on rawhide.

What's the failure?  The whole point of f48ab7d8 is that the use of
'python-config' is optional, and should not be fatal if it is not found.
 Requiring it in the specfile feels like a step backwards, and probably
breaks on RHEL 5, where we still want 'make rpm' to work.

> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  libvirt.spec.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 0959483..083612c 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -424,6 +424,7 @@ BuildRequires: automake
>  BuildRequires: gettext-devel
>  BuildRequires: libtool
>  BuildRequires: /usr/bin/pod2man
> +BuildRequires: python-devel

I'm inclined to NACK this without more evidence why it is needed, in
case we come up with a better way to fix the real problem.

>  %endif
>  BuildRequires: git
>  BuildRequires: perl
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141201/79451664/attachment-0001.sig>