[libvirt] [PATCH] libvirt.spec.in: BuildRequires: python-devel

[Jiri Denemark]

On Tue, Dec 02, 2014 at 09:11:56 +0100, Michal Privoznik wrote:
> On 01.12.2014 22:32, Eric Blake wrote:
> > On 12/01/2014 09:21 AM, Michal Privoznik wrote:
> >> As of f48ab7d8 we are trying to use python-devel to check python's
> >> version (or at least gnulib is doing that). However, the specfile
> >> doesn't say anything about it and therefore bootstrapping may fail
> >> on a minimal installation on rawhide.
> >
> > What's the failure?  The whole point of f48ab7d8 is that the use of
> > 'python-config' is optional, and should not be fatal if it is not found.
> >   Requiring it in the specfile feels like a step backwards, and probably
> > breaks on RHEL 5, where we still want 'make rpm' to work.
> 
> Do we?
> 
> [zippy at localhost libvirt.git]$ cat /etc/fedora-release
> Fedora release 22 (Rawhide)
> [zippy at localhost libvirt.git]$ rpm -q python-devel
> package python-devel is not installed
> [zippy at localhost libvirt.git]$ git clean -fxd; ./autogen.sh --system
> Removing AUTHORS
> Removing ChangeLog
> Running ./configure with --prefix=/usr --sysconfdir=/etc 
> --localstatedir=/var --libdir=/usr/lib64
> running bootstrap...
> ./bootstrap: Error: 'python-config' not found
> 
> ./bootstrap: Please install the prerequisite programs
> Failed to bootstrap, please investigate.
> [zippy at localhost libvirt.git]$

But requiring python-devel in libvirt.spec is not going to help you with
this in any way. RPMs can be built only after you have bootstrapped
libvirt. And I guess at that point, python-devel is no longer required
or is it?

Jirka