[libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

[Luyao Huang]

Sorry i didn't know that, i will pay attention next time.

And i have send a v2(but i haven't work in FreeBSD before, so...):
https://www.redhat.com/archives/libvir-list/2014-December/msg00207.html

Thanks,
Luyao Huang
----- Original Message -----
From: "Martin Kletzander" <mkletzan at redhat.com>
To: "Luyao Huang" <lhuang at redhat.com>
Cc: libvir-list at redhat.com
Sent: Monday, December 1, 2014 11:41:59 PM
Subject: Re: [libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

On Mon, Dec 01, 2014 at 11:30:09PM +0800, Luyao Huang wrote:
>
>On 12/01/2014 06:27 PM, Martin Kletzander wrote:
>> On Mon, Dec 01, 2014 at 11:17:54AM +0100, Martin Kletzander wrote:
>>> On Mon, Dec 01, 2014 at 05:54:35PM +0800, Luyao Huang wrote:
>>>> There are some small issue in qemuProcessAttach:
>>>>
>>>> 1.Fix virSecurityManagerGetProcessLabel always get pid = 0,
>>>> move 'vm->pid = pid' before call virSecurityManagerGetProcessLabel.
>>>>
>>>> 2.Use virSecurityManagerGenLabel to get image label.
>>>>
>>>> 3.Fix always set selinux label for other security driver label.
>>>>
>>>> Signed-off-by: Luyao Huang <lhuang at redhat.com>
>>>> ---
>>>> src/qemu/qemu_process.c | 10 +++++++---
>>>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>>>
>>>
>>> It looks like we were doing everything already, but we just did it
>>> wrong.  Nice catch!  ACK.
>>>
>>
>> Oh, I spoke too soon.  Two minor things are wrong with this patch that
>> I'll fixup before pushing:
>>
>> 1) The commit message summary is not very descriptive.  When someone
>>    will go over the git log he/she won't figure out what was the deal
>>    from "fix some small issue:.
>>
>Thanks for pointing out, BTW, maybe qemuprocessattach will failed after
>this patch
>without the patch 2/2, because we should give a way to get process uid
>and gid in
>virSecurityDACGetProcessLabel otherwise it will always return -1 without
>a error
>settings.
>

I missed that, those patches should've been sent in reverse order to
indicate that this one is dependant on the second one.

>I will edit Patch 2 and give a v2 in these days (otherwise i cannot use
>qemu-attach : )).
>

Looking forward to v2.

--
libvir-list mailing list
libvir-list at redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list