[libvirt] [PATCH] tests: Fix misplaced parenthesis in qemumonitorjsontest

Martin Kletzander mkletzan at redhat.com
Wed Dec 3 13:45:03 UTC 2014


When trying clang, it found out that we were comparing sizeof with 0
even though we wanted to check the return value of memcmp.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 tests/qemumonitorjsontest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index 5bfcd20..d3ae29a 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -1879,7 +1879,7 @@ testQemuMonitorJSONqemuMonitorJSONSetBlockIoThrottle(const void *data)
                                           "drive-virtio-disk0", &info, false) < 0)
         goto cleanup;

-    if (memcmp(&info, &expectedInfo, sizeof(info) != 0)) {
+    if (memcmp(&info, &expectedInfo, sizeof(info)) != 0) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        "Invalid @info");
         goto cleanup;
-- 
2.1.3




More information about the libvir-list mailing list