[libvirt] [PATCHv2] qemu: process: Refactor reconnecting to qemu processes

Peter Krempa pkrempa at redhat.com
Thu Dec 4 14:50:30 UTC 2014


On 12/04/14 15:19, Martin Kletzander wrote:
> On Thu, Dec 04, 2014 at 02:40:46PM +0100, Peter Krempa wrote:
>> Move entering the job into the thread to simplify the program flow. Also
>> as the code holds a separate reference to the domain object some
>> conditions can be simplified.
>> ---
>>
>> Notes:
>>    Version 2:
>>    - fix leak of 'data' when not reconnecting
>>
>> src/qemu/qemu_process.c | 161
>> ++++++++++++++++++++++--------------------------
>> 1 file changed, 72 insertions(+), 89 deletions(-)
>>
> 
> You can also remove the qemuDomainObjTransferJob() if you want as that
> existed only because of the reconnect function.
> 
> ACK either way, this looks much simpler now.
>
I've removed qemuDomainObjTransferJob along in this patch and pushed.

Thanks.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141204/056a8801/attachment-0001.sig>


More information about the libvir-list mailing list