[libvirt] [PATCH 02/12] getstats: improve documentation
Peter Krempa
pkrempa at redhat.com
Mon Dec 8 10:57:54 UTC 2014
On 12/06/14 09:14, Eric Blake wrote:
> At least with 'virsh domstats --block' on an offline domain, we
> currently output no stats even though we recognize the stat
> category. Although a later patch will improve this situation,
> it is better to document that this is expected behavior.
>
> Also, while the current implementation rejects filtering flags
> for virDomainListGetStats, this limitation may be lifted in the
> future and we do not enforce it at the API level.
>
> * src/libvirt-domain.c (virConnectGetAllDomainStats): Document
> that recognized stats might not be reported.
> (virDomainListGetStats): Likewise, and tweak filtering documentation.
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> src/libvirt-domain.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
ACK,
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141208/6c5dde24/attachment-0001.sig>
More information about the libvir-list
mailing list