[libvirt] [PATCH 08/12] getstats: add block.n.path stat

Peter Krempa pkrempa at redhat.com
Mon Dec 8 14:17:00 UTC 2014


On 12/06/14 09:14, Eric Blake wrote:
> I'm about to make block stats optionally more complex to cover
> backing chains, where block.count will no longer equal the number
> of <disks> for a domain.  For these reasons, it is nicer if the
> statistics output includes the source path (for local files).
> This patch doesn't add anything for network disks, although we
> may decide to add that later.
> 
> With this patch, I now see the following for the same domain as
> in earlier patches (one qcow2 file, and an empty cdrom drive):
> $ virsh domstats --block foo
> Domain: 'foo'
>   block.count=2
>   block.0.name=hda
>   block.0.path=/var/lib/libvirt/images/foo.qcow2
>   block.0.allocation=200704
>   block.0.capacity=42949672960
>   block.0.physical=200704
>   block.1.name=hdc
> 
> * src/libvirt-domain.c (virConnectGetAllDomainStats): Document
> new field.
> * tools/virsh.pod (domstats): Document new field.
> * src/qemu/qemu_driver.c (qemuDomainGetStatsBlock): Return the new
> stat for local files/block devices.
> (QEMU_ADD_NAME_PARAM): Add parameter.
> (qemuDomainGetStatsInterface): Update caller.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/libvirt-domain.c   |  3 +++
>  src/qemu/qemu_driver.c | 11 +++++++----
>  tools/virsh.pod        |  2 ++
>  3 files changed, 12 insertions(+), 4 deletions(-)
> 

ACK,

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141208/557fb217/attachment-0001.sig>


More information about the libvir-list mailing list