[libvirt] [PATCH v2] storage: Check stderr when matching parted output

Martin Kletzander mkletzan at redhat.com
Wed Dec 10 10:15:06 UTC 2014


On Wed, Dec 10, 2014 at 03:14:26PM +0800, Hao Liu wrote:
>In old version of parted like parted-2.1-25, error message is shown in
>stdout when printing a disk info without disk label.
>
>    Error: /dev/sda: unrecognised disk label
>
>This line has been moved to stderr in newer version of parted. So we
>should check both stdout and stderr when locating this message.
>
>This should fix bug:
>    https://bugzilla.redhat.com/show_bug.cgi?id=1172468
>
>Signed-off-by: Hao Liu <hliu at redhat.com>
>---
>V2: (Courtesy of Luyang Huang)
>    Fixed memory leak;
>    Fixed curly brace style;
>
> src/storage/storage_backend_disk.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>

ACK && Will push in a while.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141210/d5550ad8/attachment-0001.sig>


More information about the libvir-list mailing list