[libvirt] [PATCH V2 1/5] Add public API virDomainSendSysrq

[Daniel P. Berrange]

On Fri, Dec 12, 2014 at 05:04:13PM +0800, Chunyan Liu wrote:
> Add public API virDomainSendSysrq for sending SysRequest key.
> 
> Signed-off-by: Chunyan Liu <cyliu at suse.com>
> ---
>  include/libvirt/libvirt-domain.h |  3 +++
>  src/driver-hypervisor.h          |  4 ++++
>  src/libvirt-domain.c             | 38 ++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms          |  1 +
>  4 files changed, 46 insertions(+)
> 
> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
> index ae2c49c..73ef6c8 100644
> --- a/include/libvirt/libvirt-domain.h
> +++ b/include/libvirt/libvirt-domain.h
> @@ -3519,6 +3519,9 @@ int virDomainGetFSInfo(virDomainPtr dom,
>                         virDomainFSInfoPtr **info,
>                         unsigned int flags);
>  
> +/* virDomainSendSysrq */
> +int virDomainSendSysrq(virDomainPtr dom, const char *key);

Sysrq is just a single key press, so can't we use 'char key' instead
of a string.

Also you need to add 'unsigned int flags'.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|