[libvirt] [PATCH V2 2/5] implement remote protocol for domainSendSysrq

[Peter Krempa]

On 12/12/14 12:49, John Ferlan wrote:
> 
> 
> On 12/12/2014 04:04 AM, Chunyan Liu wrote:
>> Signed-off-by: Chunyan Liu <cyliu at suse.com>
>> ---
>>  src/remote/remote_driver.c   |  2 +-
>>  src/remote/remote_protocol.x | 13 ++++++++++++-
>>  2 files changed, 13 insertions(+), 2 deletions(-)
>>

>>  struct remote_domain_send_process_signal_args {
>>      remote_nonnull_domain dom;
>>      hyper pid_value;
>> @@ -5550,5 +5555,11 @@ enum remote_procedure {
>>       * @generate: none
>>       * @acl: domain:fs_freeze
>>       */
>> -    REMOTE_PROC_DOMAIN_GET_FSINFO = 349
>> +    REMOTE_PROC_DOMAIN_GET_FSINFO = 349,
>> +
>> +    /**
>> +     * @generate: both
>> +     * @acl: domain:send_input
>> +     */
> 
> Just send_input?  The result of the send is essentially 'init_control'
> right? Like a shutdown. Perhaps even like destroy (eg, 'stop'). Or
> 'shutdown'... I'm not sure of all the options here, but this seems much
> more invasive than just sending input because the result of the sent key
> is a bit more "final".

Since you are able to do the same thing with the virDomainSendKey API
which has the same ACL class:

virsh send-key dom KEY_LEFTALT KEY_SYSRQ KEY_O

I don't think it should require any other permission since it's just a
keystroke basically.


Peter

> 
> John
>> +    REMOTE_PROC_DOMAIN_SEND_SYSRQ = 350
>>  };
>>
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141212/042468e4/attachment-0001.sig>