[libvirt] [PATCH 0/2] Refactor safezero and virStorageFileResize

Michal Privoznik mprivozn at redhat.com
Tue Dec 16 14:36:03 UTC 2014


On 15.12.2014 22:13, John Ferlan wrote:
> Originally included as part of a series to fix a problem with file creation
> and resize within NFS storage pools that ended up being an issue somewhere
> lower in the stack of posix_fallocate or the setting of the block size in
> the meta data.  The following two patches extract out the refactoring of
> safezero and reworking virStorageFileResize to utilize safezero instead.
>
> Original series and review comments for comparison:
>
> http://www.redhat.com/archives/libvir-list/2014-August/msg00491.html
>
> I figured rather than lose any of the code and there is some value in
> utilizing the same code in order to handle a similar function that I'd
> repost as a separate series.
>
> John Ferlan (2):
>    virfile: Refactor safezero
>    virstoragefile: Have virStorageFileResize use safezero
>
>   src/locking/lock_driver_sanlock.c |  4 +--
>   src/storage/storage_backend.c     |  2 +-
>   src/util/virfile.c                | 63 +++++++++++++++++++++++++++++++++------
>   src/util/virfile.h                |  2 +-
>   src/util/virstoragefile.c         | 29 ++++++------------
>   5 files changed, 67 insertions(+), 33 deletions(-)
>

ACK to both

Michal




More information about the libvir-list mailing list