[libvirt] [PATCH 3/3] util: Fix fallocate stubs for mingw build
Eric Blake
eblake at redhat.com
Tue Dec 16 19:51:22 UTC 2014
On 12/16/2014 12:13 PM, Martin Kletzander wrote:
> When any of the functions modified in commit 214c687b took false branch,
> the function itself used none of its parameters resulting in "unused
> parameter" error. Rewriting these functions to the stubs we use
> elsewhere should fix the problem.
>
> +#else /* !HAVE_MMAP */
> +static int
> +safezero_mmap(int fd ATTRIBUTE_UNUSED,
> + off_t offset ATTRIBUTE_UNUSED,
> + off_t lenATTRIBUTE_UNUSED)
Shoot. I caught (and you corrected) the missing space...
> +{
> + return -1
...but we missed the missing ';', which means this code still won't
compile for someone without mmap. I'll push the obvious followup.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141216/aced10d9/attachment-0001.sig>
More information about the libvir-list
mailing list