[libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq
Chun Yan Liu
cyliu at suse.com
Thu Dec 18 05:00:56 UTC 2014
>>> On 12/17/2014 at 06:52 PM, in message <20141217105227.GQ136165 at orkuz.home>,
Jiri Denemark <jdenemar at redhat.com> wrote:
> On Wed, Dec 17, 2014 at 16:48:52 +0800, Chunyan Liu wrote:
> > Add public API virDomainSendSysrq for sending SysRequest key.
> >
> > Signed-off-by: Chunyan Liu <cyliu at suse.com>
> > ---
> > changes:
> > * add 'flags' to the new API
> > * change parameter from 'const char *key' to 'char key'
> > * change version number from 1.2.11 to 1.2.12
> >
> > include/libvirt/libvirt-domain.h | 3 +++
> > src/driver-hypervisor.h | 4 ++++
> > src/libvirt-domain.c | 39
> +++++++++++++++++++++++++++++++++++++++
> > src/libvirt_public.syms | 5 +++++
> > 4 files changed, 51 insertions(+)
> >
> > diff --git a/include/libvirt/libvirt-domain.h
> b/include/libvirt/libvirt-domain.h
> > index baef32d..5f72850 100644
> > --- a/include/libvirt/libvirt-domain.h
> > +++ b/include/libvirt/libvirt-domain.h
> > @@ -3526,6 +3526,9 @@ int virDomainGetFSInfo(virDomainPtr dom,
> > virDomainFSInfoPtr **info,
> > unsigned int flags);
> >
> > +/* virDomainSendSysrq */
> > +int virDomainSendSysrq(virDomainPtr dom, char key, unsigned int flags);
> > +
>
> I think quite a few reviewers (Daniel, Eric, and I) agreed on using an
> enum instead of char so that the API is more general.
Sorry, I missed this part. I'll update. One left question:
* How about 'virsh sysrq' parameters? What would we expect users to pass?
>
> Jirka
>
>
More information about the libvir-list
mailing list