[libvirt] [PATCH] util: Fix possible NULL dereference

[Michal Privoznik]

On 19.12.2014 18:15, Martin Kletzander wrote:
> Commit 1a80b97d, which added the virCgroupHasEmptyTasks() function
> forgot that the parameter @cgroup may be NULL and did not check that.
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>   src/util/vircgroup.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
> index 4857ef3..64bc647 100644
> --- a/src/util/vircgroup.c
> +++ b/src/util/vircgroup.c
> @@ -3932,6 +3932,9 @@ virCgroupHasEmptyTasks(virCgroupPtr cgroup, int controller)
>       int ret = -1;
>       char *content = NULL;
>
> +    if (!cgroup)
> +        return -1;
> +
>       ret = virCgroupGetValueStr(cgroup, controller, "tasks", &content);
>
>       if (ret == 0 && content[0] == '\0')
>

ACK

Michal