[libvirt] [PATCH] parallels: report, that cdrom image is raw

Martin Kletzander mkletzan at redhat.com
Tue Dec 23 14:15:21 UTC 2014


On Tue, Dec 23, 2014 at 04:23:34PM +0300, Dmitry Guryanov wrote:
>VIR_STORAGE_FILE_AUTO should be used only in xml provided to
>libvirt by user, if I understood correctly. Driver should
>set storage source format to specific disk format in
>*DomainGetXMLDesc.
>
>CDROMs in PCS use raw image format.
>
>Signed-off-by: Dmitry Guryanov <dguryanov at parallels.com>
>---
> src/parallels/parallels_sdk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
>index 05b1049..7aa50ee 100644
>--- a/src/parallels/parallels_sdk.c
>+++ b/src/parallels/parallels_sdk.c
>@@ -471,7 +471,7 @@ prlsdkGetDiskInfo(PRL_HANDLE prldisk,
>     if (emulatedType == PDT_USE_IMAGE_FILE) {
>         virDomainDiskSetType(disk, VIR_STORAGE_TYPE_FILE);
>         if (isCdrom)
>-            virDomainDiskSetFormat(disk, VIR_STORAGE_FILE_AUTO);
>+            virDomainDiskSetFormat(disk, VIR_STORAGE_FILE_RAW);
>         else
>             virDomainDiskSetFormat(disk, VIR_STORAGE_FILE_PLOOP);
>     } else {
>--
>2.1.0
>

ACK && Pushed.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141223/e622f15d/attachment-0001.sig>


More information about the libvir-list mailing list