[libvirt] [PATCH] virDomainBlockStats(Flags): Produce saner error message on empty disk path

Martin Kletzander mkletzan at redhat.com
Fri Feb 28 09:44:38 UTC 2014


On Fri, Feb 28, 2014 at 10:18:09AM +0100, Michal Privoznik wrote:
> As of 0bd2ccdec an empty disk path for virDomainBlockStats (or the one
> with Flags) is allowed meaning "get me overall summarized statistics".
> However, running 'virsh domblkstat $dom' throws a misleading error:
>
>   # ./tools/virsh domblkstat dom
>   error: Failed to get block stats dom
>   error: invalid argument: invalid path:
>
> while after this commit
>
>   # virsh domblkstat dom
>   error: Operation not supported: summary statistics are not supported yet
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---

ACK and worth this release, thanks!

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140228/b2e30a20/attachment-0001.sig>


More information about the libvir-list mailing list