[libvirt] [PATCHv2 2/2] network: change default of forwardPlainNames to 'yes'

Ján Tomko jtomko at redhat.com
Mon Feb 3 12:15:40 UTC 2014


On 01/31/2014 03:25 PM, Laine Stump wrote:
> The previous patch fixed "forwardPlainNames" so that it really is
> doing only what is intended, but left the default to be
> "forwardPlainNames='no'". Discussion around the initial version of
> that patch led to the decision that the default should instead be
> "forwardPlainNames='yes'" (i.e. the original behavior before commit
> f3886825). This patch makes that change to the default.
> ---

The code looks OK to me (doing what it says it does), but I don't have an
opinion on what the default should be.

Jan

>  src/conf/network_conf.c                            | 32 +++++++++++++++-------
>  src/conf/network_conf.h                            | 17 ++++++++++--
>  src/network/bridge_driver.c                        |  3 +-
>  tests/networkxml2confdata/dhcp6-nat-network.conf   |  2 --
>  tests/networkxml2confdata/dhcp6-network.conf       |  2 --
>  .../dhcp6host-routed-network.conf                  |  2 --
>  tests/networkxml2confdata/isolated-network.conf    |  2 --
>  .../nat-network-dns-forwarders.conf                |  2 --
>  .../nat-network-dns-srv-record-minimal.conf        |  2 --
>  .../nat-network-dns-srv-record.conf                |  2 --
>  .../nat-network-dns-txt-record.conf                |  2 --
>  tests/networkxml2confdata/nat-network.conf         |  2 --
>  tests/networkxml2confdata/netboot-network.conf     |  2 --
>  .../networkxml2confdata/netboot-proxy-network.conf |  2 --
>  tests/networkxml2confdata/routed-network.conf      |  2 --
>  tests/networkxml2xmlout/nat-network-dns-hosts.xml  |  2 +-
>  .../nat-network-dns-more-hosts.xml                 |  2 +-
>  .../nat-network-no-hosts.xml                       |  1 +
>  18 files changed, 42 insertions(+), 39 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140203/8b8a4d60/attachment-0001.sig>


More information about the libvir-list mailing list