[libvirt] [PATCH] qemu: minor cleanups

Christophe Fergeau cfergeau at redhat.com
Mon Feb 3 20:48:10 UTC 2014


On Mon, Feb 03, 2014 at 09:31:11PM +0100, Martin Kletzander wrote:
> On Mon, Feb 03, 2014 at 06:52:49PM +0100, Christophe Fergeau wrote:
> > Not sure this one improves things, the type of the enum is in the
> > namespacing of the values anyway (VIR_DOMAIN_CHR_TYPE_*), and it's only
> > done for a minority of the switch() calls in domain_conf.c
> >
> I like the idea of listing all the enums and compiler reminding about
> places depending on them.

Yup, I did not realize the cast would let the compiler warn about missing
enum values, so just disregard my comment about the casts. Thanks to Eric
and you for the explanation :)

Christophe


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140203/4dc0c17b/attachment-0001.sig>


More information about the libvir-list mailing list