[libvirt] [libvirt-glib 6/5] gconfig: Adjust transfer annotation for gvir_config_domain_os_get_boot_devices()

Christophe Fergeau cfergeau at redhat.com
Tue Feb 4 13:01:13 UTC 2014


(transfer container) is more correct than (transfer full) for GList of
scalar values, it's not clear whether it's an issue or not, but better be
safe than sorry.
---

I'll push this patch too in order to be fully sure that this will not be an issue,
someone on #introspection told me:
teuf: if you use transfer full, I think the bindings will assume you're
      using a list of allocated integers, and free the glist contents.
      I don't know the rules for pointer types, though, so it may be the
      case that transfer full/container are the same in this case

Christophe

 libvirt-gconfig/libvirt-gconfig-domain-os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.c b/libvirt-gconfig/libvirt-gconfig-domain-os.c
index b922a0e..429f75a 100644
--- a/libvirt-gconfig/libvirt-gconfig-domain-os.c
+++ b/libvirt-gconfig/libvirt-gconfig-domain-os.c
@@ -269,7 +269,7 @@ static gboolean add_boot_device(xmlNodePtr node, gpointer opaque)
  * Gets the list of devices attached to @os. The returned list should be
  * freed with g_list_free().
  *
- * Returns: (element-type LibvirtGConfig.DomainOsBootDevice) (transfer full):
+ * Returns: (element-type LibvirtGConfig.DomainOsBootDevice) (transfer container):
  * a newly allocated #GList of #GVirConfigDomainOsBootDevice.
  */
 GList *gvir_config_domain_os_get_boot_devices(GVirConfigDomainOs *os)
-- 
1.8.5.3




More information about the libvir-list mailing list