[libvirt] [PATCHv3 00/10] Add BlkIO and CPU/mem stat API implementations for lxc

Michal Privoznik mprivozn at redhat.com
Thu Feb 6 11:45:54 UTC 2014


On 03.02.2014 18:44, Thorsten Behrens wrote:
> This patch set adds block io, memory and domain cpu statistics API
> slot implementations to the LXC driver, in order to get linux
> container monitoring and accounting a bit closer to qemu standards.
>
> The last patch is a tad quirky (happy to hear suggestions on
> alternative ways), in that it widens the permissible value set
> at the .domainBlockStats slot: for lxc guests, it is relatively
> likely to have zero disk devices, since host filesystems can be
> used via passthrough bind mounts. Therefore, passing the zero-length
> string as device path, is interpreted as 'return summary stats for
> the entire domains's block io'.

Right. We can add test for both, can't we?

Anyway, I've ACKed most of the patches except a few. Can you please fix 
& resend them? I'll do the review and (hopefully) push them too. Nice work!

Michal




More information about the libvir-list mailing list