[libvirt] [PATCH 02/14] Fix path used for USB device attach with LXC

Eric Blake eblake at redhat.com
Fri Feb 7 15:58:06 UTC 2014


On 02/07/2014 08:33 AM, Daniel P. Berrange wrote:
> The LXC code missed the 'usb' component out of the path
> /dev/bus/usb/$BUSNUM/$DEVNUM, so it failed to actually
> setup cgroups for the device. This was in fact lucky
> because the call to virLXCSetupHostUsbDeviceCgroup
> was also mistakenly passing '&priv->cgroup' instead of
> just 'priv->cgroup'. So once the path is fixed, libvirtd
> would then crash trying to access the bogus virCgroupPtr
> pointer. This would have been a security issue, were it
> not for the bogus path preventing the pointer reference
> being reached.
> 

One bug masking another.  Eww.

> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/lxc/lxc_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140207/e373cbc1/attachment-0001.sig>


More information about the libvir-list mailing list