[libvirt] [PATCH 04/14] Fix reset of cgroup when detaching USB device from LXC guests

Eric Blake eblake at redhat.com
Fri Feb 7 16:30:23 UTC 2014


On 02/07/2014 08:33 AM, Daniel P. Berrange wrote:
> When detaching a USB device from an LXC guest we must remove
> the device from the cgroup ACL. Unfortunately we were telling
> the cgroup code to use the guest /dev path, not the host /dev
> path, and the guest device node had already been unlinked.
> This was, however, fortunate since the code passed &priv->cgroup
> instead of priv->cgroup, so would have crash if the device node
> were accessible.

Another case of one bug masking another.  Wow.

> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/lxc/lxc_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140207/b2bb33ac/attachment-0001.sig>


More information about the libvir-list mailing list