[libvirt] [PATCHv3 3/3] qemu: hyperv: Add support for timer enlightenments
Peter Krempa
pkrempa at redhat.com
Mon Feb 10 10:49:59 UTC 2014
On 02/07/14 21:43, Eric Blake wrote:
> On 02/07/2014 07:21 AM, Peter Krempa wrote:
>> Add a new <timer> for the HyperV reference time counter enlightenment
>> and the iTSC reference page for Windows guests.
>>
>> This feature provides a paravirtual approach to track timer events for
>> the guest (similar to kvmclock) with the option to use real hardware
>> clock on systems with a iTSC with compensation across various hosts.
>
> iTSC twice here...
>
>> ---
>> docs/formatdomain.html.in | 7 ++++-
>> docs/schemas/domaincommon.rng | 5 +++-
>> src/conf/domain_conf.c | 6 +++--
>> src/conf/domain_conf.h | 1 +
>> src/qemu/qemu_command.c | 30 ++++++++++++----------
>> .../qemuxml2argv-clock-timer-hyperv-rtc.args | 5 ++++
>> .../qemuxml2argv-clock-timer-hyperv-rtc.xml | 26 +++++++++++++++++++
>> tests/qemuxml2argvtest.c | 1 +
>> tests/qemuxml2xmltest.c | 1 +
>> 9 files changed, 65 insertions(+), 17 deletions(-)
>> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-clock-timer-hyperv-rtc.args
>> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-clock-timer-hyperv-rtc.xml
>>
>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>> index fd02864..64dd16a 100644
>> --- a/docs/formatdomain.html.in
>> +++ b/docs/formatdomain.html.in
>> @@ -1367,7 +1367,12 @@
>> being modified, and can be one of
>> "platform" (currently unsupported),
>> "hpet" (libxl, xen, qemu), "kvmclock" (qemu),
>> - "pit" (qemu), "rtc" (qemu), or "tsc" (libxl).
>> + "pit" (qemu), "rtc" (qemu), "tsc" (libxl) or "hypervclock"
>> + (qemu - <span class="since">since 1.2.2</span>).
>> +
>> + The <code>hypervclock</code> timer adds support for the
>> + reference time counter and the reference TSC page feature
>
> but TSC here. Is the 'i' prefix part of the name? It looks like one of
> the two places needs changing, but I'm not sure which.
iTSC is correct. It stands for invariant TSC - a TSC that has a constant
rate even if the CPU changes frequency. The rate and actual count is
also equal across cpus. I've fixed the shortcut.
>
> ACK with that fixed.
>
Pushed; Thanks.
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140210/c743f466/attachment-0001.sig>
More information about the libvir-list
mailing list